Reset peak memory usage for controllers executing multiple unrelated tasks#6257
Merged
dtdesign merged 2 commits intoWoltLab:6.1from Mar 28, 2025
TimWolla:memory-reset-peak-usage
Merged
Reset peak memory usage for controllers executing multiple unrelated tasks#6257dtdesign merged 2 commits intoWoltLab:6.1from TimWolla:memory-reset-peak-usage
dtdesign merged 2 commits intoWoltLab:6.1from
TimWolla:memory-reset-peak-usage
Conversation
This is specifically implemented in the controller instead of the BackgroundQueueHandler, since the controller only has a single purpose: Executing multiple different and a-priori unknown jobs. Measuring the peak memory usage of the entire request is not useful there. For other, user-facing, controllers the peak memory usage of an entire request is more meaningful, since they also perform other tasks besides executing background jobs. Thus we do not perform the reset in a generic location.
…cuteCronjobs() The same reasoning as with the background jobs applies. The `executeCronjobs()` method is the method that performs several a-priori unknown cronjobs and is only used for purpose-built controllers.
dtdesign
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.